spi: spi-sun6i: sun6i_spi_transfer_one(): remove not needed masking of transfer length (2130be57) · Commits · 戴 / test

In sun6i_spi_transfer_one() the driver ensures that the length of the transfer is smaller or equal to SUN6I_MAX_XFER_SIZE. This means the masking of the length to SUN6I_MAX_XFER_SIZE can be skipped when writing the transfer length into the registers. This patch removes the useless masking of the transfer length to SUN6I_MAX_XFER_SIZE. Signed-off-by:

Marc Kleine-Budde <mkl@pengutronix.de> Acked-by:

Maxime Ripard <mripard@kernel.org> Link: https://lore.kernel.org/r/20200706143443.9855-5-mkl@pengutronix.de Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi-sun6i.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -73,13 +73,10 @@
		#define SUN6I_MAX_XFER_SIZE 0xffffff

		#define SUN6I_BURST_CNT_REG 0x30
		#define SUN6I_BURST_CNT(cnt) ((cnt) & SUN6I_MAX_XFER_SIZE)

		#define SUN6I_XMIT_CNT_REG 0x34
		#define SUN6I_XMIT_CNT(cnt) ((cnt) & SUN6I_MAX_XFER_SIZE)

		#define SUN6I_BURST_CTL_CNT_REG 0x38
		#define SUN6I_BURST_CTL_CNT_STC(cnt) ((cnt) & SUN6I_MAX_XFER_SIZE)

		#define SUN6I_TXDATA_REG 0x200
		#define SUN6I_RXDATA_REG 0x300
		@@ -305,10 +302,9 @@ static int sun6i_spi_transfer_one(struct spi_master *master,
		tx_len = tfr->len;

		/* Setup the counters */
		sun6i_spi_write(sspi, SUN6I_BURST_CNT_REG, SUN6I_BURST_CNT(tfr->len));
		sun6i_spi_write(sspi, SUN6I_XMIT_CNT_REG, SUN6I_XMIT_CNT(tx_len));
		sun6i_spi_write(sspi, SUN6I_BURST_CTL_CNT_REG,
		SUN6I_BURST_CTL_CNT_STC(tx_len));
		sun6i_spi_write(sspi, SUN6I_BURST_CNT_REG, tfr->len);
		sun6i_spi_write(sspi, SUN6I_XMIT_CNT_REG, tx_len);
		sun6i_spi_write(sspi, SUN6I_BURST_CTL_CNT_REG, tx_len);

		/* Fill the TX FIFO */
		sun6i_spi_fill_fifo(sspi, sspi->fifo_depth);

Admin message