Commit 212ea99a authored by Marek Vasut's avatar Marek Vasut Committed by David S. Miller
Browse files

phy/micrel: Implement support for KSZ8021 



The KSZ8021 PHY was previously caught by KS8051, which is not correct.
This PHY needs additional setup if it is strapped for address 0. In such
case an reserved bit must be written in the 0x16, "Operation Mode Strap
Override" register. According to the KS8051 datasheet, that bit means
"PHY Address 0 in non-broadcast" and it indeed behaves as such on KSZ8021.
The issue where the ethernet controller (Freescale FEC) did not communicate
with network is fixed by writing this bit as 1.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: David J. Choi <david.choi@micrel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b018d57

drivers/net/phy/micrel.c

+27 −0
Original line number Original line Diff line number Diff line
@@ -21,6 +21,12 @@ 
#include <linux/phy.h>

#include <linux/phy.h>

#include <linux/micrel_phy.h>

#include <linux/micrel_phy.h>





/* Operation Mode Strap Override */

#define MII_KSZPHY_OMSO				0x16

#define KSZPHY_OMSO_B_CAST_OFF			(1 << 9)

#define KSZPHY_OMSO_RMII_OVERRIDE		(1 << 1)

#define KSZPHY_OMSO_MII_OVERRIDE		(1 << 0)



/* general Interrupt control/status reg in vendor specific block. */

/* general Interrupt control/status reg in vendor specific block. */

#define MII_KSZPHY_INTCS			0x1B

#define MII_KSZPHY_INTCS			0x1B

#define	KSZPHY_INTCS_JABBER			(1 << 15)

#define	KSZPHY_INTCS_JABBER			(1 << 15)
@@ -101,6 +107,13 @@ static int kszphy_config_init(struct phy_device *phydev) 
	return 0;

	return 0;

}

}





static int ksz8021_config_init(struct phy_device *phydev)

{

	const u16 val = KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE;

	phy_write(phydev, MII_KSZPHY_OMSO, val);

	return 0;

}



static int ks8051_config_init(struct phy_device *phydev)

static int ks8051_config_init(struct phy_device *phydev)

{

{

	int regval;

	int regval;
@@ -127,6 +140,19 @@ static struct phy_driver ksphy_driver[] = { 
	.ack_interrupt	= kszphy_ack_interrupt,

	.ack_interrupt	= kszphy_ack_interrupt,

	.config_intr	= ks8737_config_intr,

	.config_intr	= ks8737_config_intr,

	.driver		= { .owner = THIS_MODULE,},

	.driver		= { .owner = THIS_MODULE,},

}, {

	.phy_id		= PHY_ID_KSZ8021,

	.phy_id_mask	= 0x00ffffff,

	.name		= "Micrel KSZ8021",

	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause |

			   SUPPORTED_Asym_Pause),

	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,

	.config_init	= ksz8021_config_init,

	.config_aneg	= genphy_config_aneg,

	.read_status	= genphy_read_status,

	.ack_interrupt	= kszphy_ack_interrupt,

	.config_intr	= kszphy_config_intr,

	.driver		= { .owner = THIS_MODULE,},

}, {

}, {

	.phy_id		= PHY_ID_KS8041,

	.phy_id		= PHY_ID_KS8041,

	.phy_id_mask	= 0x00fffff0,

	.phy_id_mask	= 0x00fffff0,
@@ -203,6 +229,7 @@ static struct mdio_device_id __maybe_unused micrel_tbl[] = { 
	{ PHY_ID_KSZ9021, 0x000ffffe },

	{ PHY_ID_KSZ9021, 0x000ffffe },

	{ PHY_ID_KS8001, 0x00ffffff },

	{ PHY_ID_KS8001, 0x00ffffff },

	{ PHY_ID_KS8737, 0x00fffff0 },

	{ PHY_ID_KS8737, 0x00fffff0 },

	{ PHY_ID_KSZ8021, 0x00ffffff },

	{ PHY_ID_KS8041, 0x00fffff0 },

	{ PHY_ID_KS8041, 0x00fffff0 },

	{ PHY_ID_KS8051, 0x00fffff0 },

	{ PHY_ID_KS8051, 0x00fffff0 },

	{ }

	{ }

include/linux/micrel_phy.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -5,6 +5,7 @@ 




#define PHY_ID_KSZ9021		0x00221610

#define PHY_ID_KSZ9021		0x00221610

#define PHY_ID_KS8737		0x00221720

#define PHY_ID_KS8737		0x00221720

#define PHY_ID_KSZ8021		0x00221555

#define PHY_ID_KS8041		0x00221510

#define PHY_ID_KS8041		0x00221510

#define PHY_ID_KS8051		0x00221550

#define PHY_ID_KS8051		0x00221550

/* both for ks8001 Rev. A/B, and for ks8721 Rev 3. */

/* both for ks8001 Rev. A/B, and for ks8721 Rev 3. */

CRA Git | Maintained and supported by SUSTech CRA and CCSE