Commit 21225336 authored Nov 28, 2020 by Paulo Alcantara Committed by Steve French Nov 30, 2020

cifs: fix potential use-after-free in cifs_echo_request()



This patch fixes a potential use-after-free bug in
cifs_echo_request().

For instance,

  thread 1
  --------
  cifs_demultiplex_thread()
    clean_demultiplex_info()
      kfree(server)

  thread 2 (workqueue)
  --------
  apic_timer_interrupt()
    smp_apic_timer_interrupt()
      irq_exit()
        __do_softirq()
          run_timer_softirq()
            call_timer_fn()
	      cifs_echo_request() <- use-after-free in server ptr

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
CC: Stable <stable@vger.kernel.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 6988a619

fs/cifs/connect.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -876,6 +876,8 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server)
		list_del_init(&server->tcp_ses_list);
		spin_unlock(&cifs_tcp_ses_lock);

		cancel_delayed_work_sync(&server->echo);

		spin_lock(&GlobalMid_Lock);
		server->tcpStatus = CifsExiting;
		spin_unlock(&GlobalMid_Lock);

Admin message