Commit 212244f7 authored Apr 22, 2019 by Guenter Roeck

hwmon: (max6650) Drop call to thermal_cdev_update

The call to thermal_cdev_update() causes any fan connected to the chip
to stop immediately. If the thermal subsystem is not set up to actually
handle the chip as cooling device, the remains stopped until is is
restarted manually with a write to a sysfs attribute.

There is evidence that thermal_cdev_update() should only be called from
thermal governors, not from thermal cooling device drivers. Drop the call.

Cc: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Tested-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent f786dbbe

drivers/hwmon/max6650.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -801,8 +801,6 @@ static int max6650_probe(struct i2c_client *client,
		dev_warn(&client->dev,
		"thermal cooling device register failed: %ld\n",
		PTR_ERR(data->cooling_dev));
		else
		thermal_cdev_update(data->cooling_dev);
		#endif
		return 0;
		}

Admin message