scsi: st: mark expected switch fall-throughs (211d62a8) · Commits · 戴 / test

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114994 ("Missing break in switch") Addresses-Coverity-ID: 114995 ("Missing break in switch") Signed-off-by:

Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by:

Kai Mäkisara <kai.makisara@kolumbus.fi> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/st.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -337,12 +337,14 @@ static void st_analyze_sense(struct st_request SRpnt, struct st_cmdstatus s)
		switch (sense[0] & 0x7f) {
		case 0x71:
		s->deferred = 1;
		/* fall through */
		case 0x70:
		s->fixed_format = 1;
		s->flags = sense[2] & 0xe0;
		break;
		case 0x73:
		s->deferred = 1;
		/* fall through */
		case 0x72:
		s->fixed_format = 0;
		ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4);
		@@ -2721,6 +2723,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
		switch (cmd_in) {
		case MTFSFM:
		chg_eof = 0; /* Changed from the FSF after this */
		/* fall through */
		case MTFSF:
		cmd[0] = SPACE;
		cmd[1] = 0x01; /* Space FileMarks */
		@@ -2735,6 +2738,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
		break;
		case MTBSFM:
		chg_eof = 0; /* Changed from the FSF after this */
		/* fall through */
		case MTBSF:
		cmd[0] = SPACE;
		cmd[1] = 0x01; /* Space FileMarks */

Admin message