Commit 211186ca authored Jul 11, 2019 by Lei YU Committed by Guenter Roeck Jul 21, 2019

hwmon: (occ) Fix division by zero issue



The code in occ_get_powr_avg() invokes div64_u64() without checking the
divisor. In case the divisor is zero, kernel gets an "Division by zero
in kernel" error.

Check the divisor and make it return 0 if the divisor is 0.

Fixes: c10e753d ("hwmon (occ): Add sensor types and versions")
Signed-off-by: Lei YU <mine260309@gmail.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/1562813088-23708-1-git-send-email-mine260309@gmail.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 5f9e832c

drivers/hwmon/occ/common.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -408,8 +408,10 @@ static ssize_t occ_show_power_1(struct device *dev,

		static u64 occ_get_powr_avg(u64 accum, u32 samples)
		{
		return div64_u64(get_unaligned_be64(accum) * 1000000ULL,
		get_unaligned_be32(samples));
		u64 divisor = get_unaligned_be32(samples);

		return (divisor == 0) ? 0 :
		div64_u64(get_unaligned_be64(accum) * 1000000ULL, divisor);
		}

		static ssize_t occ_show_power_2(struct device *dev,

Admin message