Commit 20ea39ef authored Feb 20, 2019 by Lars-Peter Clausen Committed by Jonathan Cameron Mar 09, 2019

iio: Fix scan mask selection

The trialmask is expected to have all bits set to 0 after allocation.
Currently kmalloc_array() is used which does not zero the memory and so
random bits are set. This results in random channels being enabled when
they shouldn't. Replace kmalloc_array() with kcalloc() which has the same
interface but zeros the memory.

Note the fix is actually required earlier than the below fixes tag, but
will require a manual backport due to move from kmalloc to kmalloc_array.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes commit 057ac1ac ("iio: Use kmalloc_array() in iio_scan_mask_set()").
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 7ce0f216

drivers/iio/industrialio-buffer.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -320,9 +320,8 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev,
		const unsigned long *mask;
		unsigned long *trialmask;

		trialmask = kmalloc_array(BITS_TO_LONGS(indio_dev->masklength),
		sizeof(*trialmask),
		GFP_KERNEL);
		trialmask = kcalloc(BITS_TO_LONGS(indio_dev->masklength),
		sizeof(*trialmask), GFP_KERNEL);
		if (trialmask == NULL)
		return -ENOMEM;
		if (!indio_dev->masklength) {

Admin message