Commit 20cf7e3c authored Sep 18, 2017 by Colin Ian King Committed by Mark Brown Sep 19, 2017

ASoC: qcom: remove duplicate initializations of dma_ch and v



dma_ch is being initialized to zero and then immediately afterwards
being updated again, so the first initialization is redundant and
can be remove.

Likewise, the pointer v is being initialized twice, so remove the second
duplicate initialization.

Cleans up two clang build warnings:
warning: Value stored to 'dma_ch' is never read
warning: Value stored to 'v' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2bd6bf03

sound/soc/qcom/lpass-platform.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -74,7 +74,6 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream)
		data->i2s_port = cpu_dai->driver->id;
		runtime->private_data = data;

		dma_ch = 0;
		if (v->alloc_dma_channel)
		dma_ch = v->alloc_dma_channel(drvdata, dir);
		else
		@@ -122,7 +121,6 @@ static int lpass_platform_pcmops_close(struct snd_pcm_substream *substream)
		struct lpass_pcm_data *data;

		data = runtime->private_data;
		v = drvdata->variant;
		drvdata->substream[data->dma_ch] = NULL;
		if (v->free_dma_channel)
		v->free_dma_channel(drvdata, data->dma_ch);

Admin message