leds: fix sparse warnings due to missing static (20c0e6b8) · Commits · 戴 / test

drivers/leds/led-core.c:56:6: sparse: symbol 'led_blink_setup' was not declared. Should it be static? drivers/leds/led-triggers.c:233:6: sparse: symbol 'led_trigger_blink_setup' was not declared. Should it be static? Reported-by:

Fengguang Wu <wfg@linux.intel.com> Signed-off-by:

Bryan Wu <bryan.wu@canonical.com>

drivers/leds/led-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -53,7 +53,7 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
		}


		void led_blink_setup(struct led_classdev *led_cdev,
		static void led_blink_setup(struct led_classdev *led_cdev,
		unsigned long *delay_on,
		unsigned long *delay_off)
		{

drivers/leds/led-triggers.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -230,7 +230,7 @@ void led_trigger_event(struct led_trigger *trig,
		}
		EXPORT_SYMBOL_GPL(led_trigger_event);

		void led_trigger_blink_setup(struct led_trigger *trig,
		static void led_trigger_blink_setup(struct led_trigger *trig,
		unsigned long *delay_on,
		unsigned long *delay_off,
		int oneshot,

Admin message