Commit 20bd723e authored by Paolo Valente's avatar Paolo Valente Committed by Jens Axboe
Browse files

block: add missing group association in bio-cloning functions 



When a bio is cloned, the newly created bio must be associated with
the same blkcg as the original bio (if BLK_CGROUP is enabled). If
this operation is not performed, then the new bio is not associated
with any group, and the group of the current task is returned when
the group of the bio is requested.

Depending on the cloning frequency, this may cause a large
percentage of the bios belonging to a given group to be treated
as if belonging to other groups (in most cases as if belonging to
the root group). The expected group isolation may thereby be broken.

This commit adds the missing association in bio-cloning functions.

Fixes: da2f0f74 ("Btrfs: add support for blkio controllers")
Cc: stable@vger.kernel.org # v4.3+

Signed-off-by: default avatarPaolo Valente <paolo.valente@linaro.org>
Reviewed-by: default avatarNikolay Borisov <kernel@kyup.com>
Reviewed-by: default avatarJeff Moyer <jmoyer@redhat.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent bfd279a8

block/bio.c

+15 −0
Original line number Diff line number Diff line
@@ -583,6 +583,8 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) 
	bio->bi_rw = bio_src->bi_rw;

	bio->bi_iter = bio_src->bi_iter;

	bio->bi_io_vec = bio_src->bi_io_vec;



	bio_clone_blkcg_association(bio, bio_src);

}

EXPORT_SYMBOL(__bio_clone_fast);
@@ -687,6 +689,8 @@ integrity_clone: 
		}

	}



	bio_clone_blkcg_association(bio, bio_src);



	return bio;

}

EXPORT_SYMBOL(bio_clone_bioset);
@@ -2004,6 +2008,17 @@ void bio_disassociate_task(struct bio *bio) 
	}

}



/**

 * bio_clone_blkcg_association - clone blkcg association from src to dst bio

 * @dst: destination bio

 * @src: source bio

 */

void bio_clone_blkcg_association(struct bio *dst, struct bio *src)

{

	if (src->bi_css)

		WARN_ON(bio_associate_blkcg(dst, src->bi_css));

}



#endif /* CONFIG_BLK_CGROUP */



static void __init biovec_init_slabs(void)

fs/btrfs/extent_io.c

+0 −6
Original line number Diff line number Diff line
@@ -2697,12 +2697,6 @@ struct bio *btrfs_bio_clone(struct bio *bio, gfp_t gfp_mask) 
		btrfs_bio->csum = NULL;

		btrfs_bio->csum_allocated = NULL;

		btrfs_bio->end_io = NULL;



#ifdef CONFIG_BLK_CGROUP

		/* FIXME, put this into bio_clone_bioset */

		if (bio->bi_css)

			bio_associate_blkcg(new, bio->bi_css);

#endif

	}

	return new;

}

include/linux/bio.h

+3 −0
Original line number Diff line number Diff line
@@ -470,11 +470,14 @@ extern unsigned int bvec_nr_vecs(unsigned short idx); 
int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css);

int bio_associate_current(struct bio *bio);

void bio_disassociate_task(struct bio *bio);

void bio_clone_blkcg_association(struct bio *dst, struct bio *src);

#else	/* CONFIG_BLK_CGROUP */

static inline int bio_associate_blkcg(struct bio *bio,

			struct cgroup_subsys_state *blkcg_css) { return 0; }

static inline int bio_associate_current(struct bio *bio) { return -ENOENT; }

static inline void bio_disassociate_task(struct bio *bio) { }

static inline void bio_clone_blkcg_association(struct bio *dst,

			struct bio *src) { }

#endif	/* CONFIG_BLK_CGROUP */



#ifdef CONFIG_HIGHMEM

CRA Git | Maintained and supported by SUSTech CRA and CCSE