Commit 20bb0c8f authored by Rahul Lakkireddy's avatar Rahul Lakkireddy Committed by David S. Miller
Browse files

cxgb4vf: update kernel-doc line comments 



Update several kernel-doc line comments to fix warnings reported by
make W=1.

Fixes following class of warnings reported by make W=1 in several
places:
cxgb4vf_main.c:275: warning: Function parameter or member 'persistent'
not described in 'cxgb4vf_change_mac'
cxgb4vf_main.c:275: warning: Excess function parameter 'persist'
description in 'cxgb4vf_change_mac'

Fixes: 16f8bd4b ("cxgb4vf: Add core T4 PCI-E SR-IOV Virtual Function hardware definitions and device communication code")
Fixes: c6e0d914 ("cxgb4vf: Add T4 Virtual Function Scatter-Gather Engine DMA code")
Fixes: e0a8b34a ("cxgb4vf: Add and initialize some sge params for VF driver")
Fixes: c3168cab ("cxgb4/cxgbvf: Handle 32-bit fw port capabilities")
Fixes: 0e23daeb ("drivers/net: chelsio/cxgb*: Convert timers to use timer_setup()")
Fixes: 3f8cfd0d ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()")
Signed-off-by: default avatarRahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 29bbf5d7

drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

+1 −2
Original line number Diff line number Diff line
@@ -260,8 +260,7 @@ static int cxgb4vf_set_addr_hash(struct port_info *pi) 
 *	@tcam_idx: TCAM index of existing filter for old value of MAC address,

 *		   or -1

 *	@addr: the new MAC address value

 *	@persist: whether a new MAC allocation should be persistent

 *	@add_smt: if true also add the address to the HW SMT

 *	@persistent: whether a new MAC allocation should be persistent

 *

 *	Modifies an MPS filter and sets it to the new MAC address if

 *	@tcam_idx >= 0, or adds the MAC address to a new filter if

drivers/net/ethernet/chelsio/cxgb4vf/sge.c

+4 −3
Original line number Diff line number Diff line
@@ -1692,7 +1692,7 @@ static inline bool is_new_response(const struct rsp_ctrl *rc, 
 *	restore_rx_bufs - put back a packet's RX buffers

 *	@gl: the packet gather list

 *	@fl: the SGE Free List

 *	@nfrags: how many fragments in @si

 *	@frags: how many fragments in @si

 *

 *	Called when we find out that the current packet, @si, can't be

 *	processed right away for some reason.  This is a very rare event and
@@ -2054,7 +2054,7 @@ irq_handler_t t4vf_intr_handler(struct adapter *adapter) 


/**

 *	sge_rx_timer_cb - perform periodic maintenance of SGE RX queues

 *	@data: the adapter

 *	@t: Rx timer

 *

 *	Runs periodically from a timer to perform maintenance of SGE RX queues.

 *
@@ -2113,7 +2113,7 @@ static void sge_rx_timer_cb(struct timer_list *t) 


/**

 *	sge_tx_timer_cb - perform periodic maintenance of SGE Tx queues

 *	@data: the adapter

 *	@t: Tx timer

 *

 *	Runs periodically from a timer to perform maintenance of SGE TX queues.

 *
@@ -2405,6 +2405,7 @@ err: 
 *	t4vf_sge_alloc_eth_txq - allocate an SGE Ethernet TX Queue

 *	@adapter: the adapter

 *	@txq: pointer to the new txq to be filled in

 *	@dev: the network device

 *	@devq: the network TX queue associated with the new txq

 *	@iqid: the relative ingress queue ID to which events relating to

 *		the new txq should be directed

drivers/net/ethernet/chelsio/cxgb4vf/t4vf_hw.c

+3 −6
Original line number Diff line number Diff line
@@ -389,9 +389,7 @@ static inline enum cc_fec fwcap_to_cc_fec(fw_port_cap32_t fw_fec) 
	return cc_fec;

}



/**

 * Return the highest speed set in the port capabilities, in Mb/s.

 */

/* Return the highest speed set in the port capabilities, in Mb/s. */

static unsigned int fwcap_to_speed(fw_port_cap32_t caps)

{

	#define TEST_SPEED_RETURN(__caps_speed, __speed) \
@@ -1467,6 +1465,7 @@ int t4vf_identify_port(struct adapter *adapter, unsigned int viid, 
 *	@bcast: 1 to enable broadcast Rx, 0 to disable it, -1 no change

 *	@vlanex: 1 to enable hardware VLAN Tag extraction, 0 to disable it,

 *		-1 no change

 *	@sleep_ok: call is allowed to sleep

 *

 *	Sets Rx properties of a virtual interface.

 */
@@ -1906,7 +1905,7 @@ static const char *t4vf_link_down_rc_str(unsigned char link_down_rc) 
/**

 *	t4vf_handle_get_port_info - process a FW reply message

 *	@pi: the port info

 *	@rpl: start of the FW message

 *	@cmd: start of the FW message

 *

 *	Processes a GET_PORT_INFO FW reply message.

 */
@@ -2137,8 +2136,6 @@ int t4vf_handle_fw_rpl(struct adapter *adapter, const __be64 *rpl) 
	return 0;

}



/**

 */

int t4vf_prep_adapter(struct adapter *adapter)

{

	int err;

CRA Git | Maintained and supported by SUSTech CRA and CCSE