Commit 2091a3d4 authored Mar 21, 2020 by Oliver Hartkopp Committed by David S. Miller Mar 21, 2020

slcan: not call free_netdev before rtnl_unlock in slcan_open



As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

This patch is a 1:1 copy of upstream slip.c commit f596c870
("slip: not call free_netdev before rtnl_unlock in slip_open").

Reported-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 06e9bfc1

drivers/net/can/slcan.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -625,7 +625,10 @@ err_free_chan:
	tty->disc_data = NULL;		tty->disc_data = NULL;
	clear_bit(SLF_INUSE, &sl->flags);		clear_bit(SLF_INUSE, &sl->flags);
	slc_free_netdev(sl->dev);		slc_free_netdev(sl->dev);
			/* do not call free_netdev before rtnl_unlock */
			rtnl_unlock();
	free_netdev(sl->dev);		free_netdev(sl->dev);
			return err;

	err_exit:		err_exit:
	rtnl_unlock();		rtnl_unlock();

Admin message