Commit 2081a6b5 authored by Stephen Boyd's avatar Stephen Boyd Committed by David Brown
Browse files

msm: timer: Remove SoC specific #ifdefs 



The timer frequency is currently ifdefed in addition to setting
the DGT clock's divider value on SCORPIONMP targets. Setup the
frequency dynamically using the existing cpu_is_*() branches and
assign a custom clocksource read function for 7x01a to get the
shift out of the generic path.

Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarDavid Brown <davidb@codeaurora.org>
parent 2a00c106

arch/arm/mach-msm/timer.c

+17 −21
Original line number Diff line number Diff line
@@ -40,20 +40,7 @@ 


#define GPT_HZ 32768



/* TODO: Remove these ifdefs */

#if defined(CONFIG_ARCH_QSD8X50)

#define DGT_HZ (19200000 / 4) /* 19.2 MHz / 4 by default */

#define MSM_DGT_SHIFT (0)

#elif defined(CONFIG_ARCH_MSM7X30)

#define DGT_HZ (24576000 / 4) /* 24.576 MHz (LPXO) / 4 by default */

#define MSM_DGT_SHIFT (0)

#elif defined(CONFIG_ARCH_MSM8X60) || defined(CONFIG_ARCH_MSM8960)

#define DGT_HZ (27000000 / 4) /* 27 MHz (PXO) / 4 by default */

#define MSM_DGT_SHIFT (0)

#else

#define DGT_HZ 19200000 /* 19.2 MHz or 600 KHz after shift */

#define MSM_DGT_SHIFT (5)

#endif

#define MSM_DGT_SHIFT 5



static void __iomem *event_base;
@@ -122,19 +109,24 @@ static union { 
static void __iomem *source_base;



static cycle_t msm_read_timer_count(struct clocksource *cs)

{

	return readl_relaxed(source_base + TIMER_COUNT_VAL);

}



static cycle_t msm_read_timer_count_shift(struct clocksource *cs)

{

	/*

	 * Shift timer count down by a constant due to unreliable lower bits

	 * on some targets.

	 */

	return readl_relaxed(source_base + TIMER_COUNT_VAL) >> MSM_DGT_SHIFT;

	return msm_read_timer_count(cs) >> MSM_DGT_SHIFT;

}



static struct clocksource msm_clocksource = {

	.name	= "dg_timer",

	.rating	= 300,

	.read	= msm_read_timer_count,

	.mask	= CLOCKSOURCE_MASK((32 - MSM_DGT_SHIFT)),

	.mask	= CLOCKSOURCE_MASK(32),

	.flags	= CLOCK_SOURCE_IS_CONTINUOUS,

};
@@ -143,27 +135,31 @@ static void __init msm_timer_init(void) 
	struct clock_event_device *ce = &msm_clockevent;

	struct clocksource *cs = &msm_clocksource;

	int res;

	u32 dgt_hz;



	if (cpu_is_msm7x01()) {

		event_base = MSM_CSR_BASE;

		source_base = MSM_CSR_BASE + 0x10;

		dgt_hz = 19200000 >> MSM_DGT_SHIFT; /* 600 KHz */

		cs->read = msm_read_timer_count_shift;

		cs->mask = CLOCKSOURCE_MASK((32 - MSM_DGT_SHIFT));

	} else if (cpu_is_msm7x30()) {

		event_base = MSM_CSR_BASE + 0x04;

		source_base = MSM_CSR_BASE + 0x24;

		dgt_hz = 24576000 / 4;

	} else if (cpu_is_qsd8x50()) {

		event_base = MSM_CSR_BASE;

		source_base = MSM_CSR_BASE + 0x10;

		dgt_hz = 19200000 / 4;

	} else if (cpu_is_msm8x60() || cpu_is_msm8960()) {

		event_base = MSM_TMR_BASE + 0x04;

		/* Use CPU0's timer as the global clock source. */

		source_base = MSM_TMR0_BASE + 0x24;

		dgt_hz = 27000000 / 4;

		writel_relaxed(DGT_CLK_CTL_DIV_4, MSM_TMR_BASE + DGT_CLK_CTL);

	} else

		BUG();



#ifdef CONFIG_ARCH_MSM_SCORPIONMP

	writel(DGT_CLK_CTL_DIV_4, MSM_TMR_BASE + DGT_CLK_CTL);

#endif



	writel_relaxed(0, event_base + TIMER_ENABLE);

	writel_relaxed(0, event_base + TIMER_CLEAR);

	writel_relaxed(~0, event_base + TIMER_MATCH_VAL);
@@ -201,7 +197,7 @@ static void __init msm_timer_init(void) 
	clockevents_register_device(ce);

err:

	writel_relaxed(TIMER_ENABLE_EN, source_base + TIMER_ENABLE);

	res = clocksource_register_hz(cs, DGT_HZ >> MSM_DGT_SHIFT);

	res = clocksource_register_hz(cs, dgt_hz);

	if (res)

		pr_err("clocksource_register failed\n");

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE