Commit 2070d805 authored Dec 22, 2014 by Andrew Gabbasov Committed by Ulf Hansson Jan 19, 2015

mmc: sdhci: Remove redundant ADMA page boundary warnings



The bounce buffer, used for misaligned bytes for ADMA access,
resides wholly within the (align_sz)-aligned word, just by construction.
The page addresses are aligned to (align_sz), either for 4 or 8 bytes
alignment, so that the aligned word resides wholly within a single page
and can't cross the page boundary. So, the bounce buffer can't cross
the page boundary too. That's why the warnings are never hit, and can
be safely removed.

Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 04cdbbfa

drivers/mmc/host/sdhci.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -531,8 +531,6 @@ static int sdhci_adma_table_pre(struct sdhci_host *host,
		if (offset) {
		if (data->flags & MMC_DATA_WRITE) {
		buffer = sdhci_kmap_atomic(sg, &flags);
		WARN_ON(((long)buffer & (PAGE_SIZE - 1)) >
		(PAGE_SIZE - offset));
		memcpy(align, buffer, offset);
		sdhci_kunmap_atomic(buffer, &flags);
		}
		@@ -639,8 +637,6 @@ static void sdhci_adma_table_post(struct sdhci_host *host,
		(sg_dma_address(sg) & host->align_mask);

		buffer = sdhci_kmap_atomic(sg, &flags);
		WARN_ON(((long)buffer & (PAGE_SIZE - 1)) >
		(PAGE_SIZE - size));
		memcpy(buffer, align, size);
		sdhci_kunmap_atomic(buffer, &flags);

Admin message