Commit 202500d2 authored May 22, 2020 by Peng Hao Committed by Ulf Hansson May 25, 2020

mmc: block: Fix use-after-free issue for rpmb



The data structure member “rpmb->md” was passed to a call of the function
“mmc_blk_put” after a call of the function “put_device”. Reorder these
function calls to keep the data accesses consistent.

Fixes: 1c87f735 ("mmc: block: Fix bug when removing RPMB chardev ")
Signed-off-by: Peng Hao <richard.peng@oppo.com>
Cc: stable@vger.kernel.org
[Uffe: Fixed up mangled patch and updated commit message]
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 2b17b8d7

drivers/mmc/core/block.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2484,8 +2484,8 @@ static int mmc_rpmb_chrdev_release(struct inode inode, struct file filp)
		struct mmc_rpmb_data *rpmb = container_of(inode->i_cdev,
		struct mmc_rpmb_data, chrdev);

		put_device(&rpmb->dev);
		mmc_blk_put(rpmb->md);
		put_device(&rpmb->dev);

		return 0;
		}

Admin message