Commit 2010d7fe authored Sep 01, 2007 by Kenji Kaneshige Committed by Tony Luck Oct 12, 2007

[IA64] Fix kernel hangup in kdump on INIT



Fix the problem that kdump on INIT hung up if kdump kernel image is
not configured.

The kdump_init_notifier() on monarch CPU stops its operation at
DIE_INIT_MONARCH_LEAVE time if the kdump kernel image is not
configured. On the other hand, kdump_init_notifier() on non-monarch
CPUs get into spin because they don't know the fact the monarch stops
its operation. This is the cause of this problem. To fix this problem,
we need to check the kdump kernel image at the top of the
kdump_init_notifier() function.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent ac542a51

arch/ia64/kernel/crash.c

+8 −5

Original line number	Diff line number	Diff line
		@@ -118,11 +118,6 @@ machine_crash_shutdown(struct pt_regs *pt)
		static void
		machine_kdump_on_init(void)
		{
		if (!ia64_kimage) {
		ia64_mca_printk(KERN_NOTICE "machine_kdump_on_init(): "
		"kdump not configured\n");
		return;
		}
		local_irq_disable();
		kexec_disable_iosapic();
		machine_kexec(ia64_kimage);
		@@ -156,6 +151,14 @@ kdump_init_notifier(struct notifier_block self, unsigned long val, void data)
		if (!kdump_on_init)
		return NOTIFY_DONE;

		if (!ia64_kimage) {
		if (val == DIE_INIT_MONARCH_LEAVE)
		ia64_mca_printk(KERN_NOTICE
		"%s: kdump not configured\n",
		__FUNCTION__);
		return NOTIFY_DONE;
		}

		if (val != DIE_INIT_MONARCH_LEAVE &&
		val != DIE_INIT_SLAVE_LEAVE &&
		val != DIE_INIT_MONARCH_PROCESS &&

Admin message