coresight: cpu-debug: no need to check return value of debugfs_create functions (200f3a3f) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Suzuki K Poulose <suzuki.poulose@arm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: linux-arm-kernel@lists.infradead.org Reviewed-by:

Mathieu Poirier <mathieu.poirier@linaro.org> Tested-by:

Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/hwtracing/coresight/coresight-cpu-debug.c

+2 −13

Original line number	Diff line number	Diff line
		@@ -525,23 +525,12 @@ static const struct file_operations debug_func_knob_fops = {

		static int debug_func_init(void)
		{
		struct dentry *file;
		int ret;

		/* Create debugfs node */
		debug_debugfs_dir = debugfs_create_dir("coresight_cpu_debug", NULL);
		if (!debug_debugfs_dir) {
		pr_err("%s: unable to create debugfs directory\n", __func__);
		return -ENOMEM;
		}

		file = debugfs_create_file("enable", 0644, debug_debugfs_dir, NULL,
		debugfs_create_file("enable", 0644, debug_debugfs_dir, NULL,
		&debug_func_knob_fops);
		if (!file) {
		pr_err("%s: unable to create enable knob file\n", __func__);
		ret = -ENOMEM;
		goto err;
		}

		/* Register function to be called for panic */
		ret = atomic_notifier_chain_register(&panic_notifier_list,

Admin message