selftests: net: tcp_mmap should create detached threads (20021578) · Commits · 戴 / test

Since we do not plan using pthread_join() in the server do_accept() loop, we better create detached threads, or risk increasing memory footprint over time. Fixes: ("selftests: net: add tcp_mmap program") Signed-off-by:

Eric Dumazet <edumazet@google.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

tools/testing/selftests/net/tcp_mmap.c

+6 −1

Original line number	Original line	Diff line number	Diff line
	@@ -270,6 +270,11 @@ static void setup_sockaddr(int domain, const char *str_addr,

	static void do_accept(int fdlisten)		static void do_accept(int fdlisten)
	{		{
			pthread_attr_t attr;

			pthread_attr_init(&attr);
			pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);

	if (setsockopt(fdlisten, SOL_SOCKET, SO_RCVLOWAT,		if (setsockopt(fdlisten, SOL_SOCKET, SO_RCVLOWAT,
	&chunk_size, sizeof(chunk_size)) == -1) {		&chunk_size, sizeof(chunk_size)) == -1) {
	perror("setsockopt SO_RCVLOWAT");		perror("setsockopt SO_RCVLOWAT");
	@@ -288,7 +293,7 @@ static void do_accept(int fdlisten)
	perror("accept");		perror("accept");
	continue;		continue;
	}		}
	res = pthread_create(&th, NULL, child_thread,		res = pthread_create(&th, &attr, child_thread,
	(void *)(unsigned long)fd);		(void *)(unsigned long)fd);
	if (res) {		if (res) {
	errno = res;		errno = res;

Admin message