HSI: omap_ssi_port: fix debugfs_simple_attr.cocci warnings (1ff85bfa) · Commits · 戴 / test

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Sebastian Reichel <sebastian.reichel@collabora.com>

drivers/hsi/controllers/omap_ssi_port.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -162,7 +162,7 @@ static int ssi_div_set(void *data, u64 val)
		return 0;
		}

		DEFINE_SIMPLE_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
		DEFINE_DEBUGFS_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");

		static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
		struct dentry *dir)
		@@ -177,7 +177,7 @@ static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
		dir = debugfs_create_dir("sst", dir);
		if (!dir)
		return -ENOMEM;
		debugfs_create_file("divisor", S_IRUGO \| S_IWUSR, dir, port,
		debugfs_create_file_unsafe("divisor", 0644, dir, port,
		&ssi_sst_div_fops);

		return 0;

Admin message