Commit 1feefb7e authored Oct 17, 2019 by Al Viro Committed by Martin K. Petersen Nov 06, 2019

scsi: sg: sg_ioctl(): get rid of access_ok()

simply not needed there - neither sg_new_read() nor sg_new_write() need
it.

Link: https://lore.kernel.org/r/20191017193925.25539-8-viro@ZenIV.linux.org.uk


Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent a64e5a86

drivers/scsi/sg.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -896,8 +896,6 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
		return -ENODEV;
		if (!scsi_block_when_processing_errors(sdp->device))
		return -ENXIO;
		if (!access_ok(p, SZ_SG_IO_HDR))
		return -EFAULT;
		result = sg_new_write(sfp, filp, p, SZ_SG_IO_HDR,
		1, read_only, 1, &srp);
		if (result < 0)

Admin message