kobject: Improve doc clarity kobject_init_and_add() (1fd7c3b4) · Commits · 戴 / test

Function kobject_init_and_add() is currently misused in a number of places in the kernel. On error return kobject_put() must be called but is at times not. Make the function documentation more explicit about calling kobject_put() in the error path. Signed-off-by:

Tobin C. Harding <tobin@kernel.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

lib/kobject.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -450,9 +450,12 @@ EXPORT_SYMBOL(kobject_add);
		* @parent: pointer to the parent of this kobject.
		* @fmt: the name of the kobject.
		*
		* This function combines the call to kobject_init() and
		* kobject_add(). The same type of error handling after a call to
		* kobject_add() and kobject lifetime rules are the same here.
		* This function combines the call to kobject_init() and kobject_add().
		*
		* If this function returns an error, kobject_put() must be called to
		* properly clean up the memory associated with the object. This is the
		* same type of error handling after a call to kobject_add() and kobject
		* lifetime rules are the same here.
		*/
		int kobject_init_and_add(struct kobject kobj, struct kobj_type ktype,
		struct kobject parent, const char fmt, ...)

Admin message