Commit 1fd28018 authored Jul 28, 2020 by Jaegeuk Kim

f2fs: fix deadlock between quota writes and checkpoint



f2fs_write_data_pages(quota_mapping)
 __f2fs_write_data_pages             f2fs_write_checkpoint
  * blk_start_plug(&plug);
  * add bio in write_io[DATA]
                                      - block_operations
                                      - skip syncing quota by
                                                >DEFAULT_RETRY_QUOTA_FLUSH_COUNT
                                      - down_write(&sbi->node_write);
  - f2fs_write_single_data_page
   - down_read(node_write)
                                      - f2fs_wait_on_all_pages(F2FS_WB_CP_DATA);

Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 1f07cc58

fs/f2fs/checkpoint.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1269,6 +1269,8 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, int type)
		if (type == F2FS_DIRTY_META)
		f2fs_sync_meta_pages(sbi, META, LONG_MAX,
		FS_CP_META_IO);
		else if (type == F2FS_WB_CP_DATA)
		f2fs_submit_merged_write(sbi, DATA);
		io_schedule_timeout(DEFAULT_IO_TIMEOUT);
		}
		finish_wait(&sbi->cp_wait, &wait);

Admin message