Commit 1fd213f3 authored Mar 02, 2020 by Anson Huang Committed by Daniel Lezcano Mar 12, 2020

thermal: imx_sc_thermal: Align imx sc thermal msg structs to 4

The i.MX SCU API strongly assumes that messages are composed out
of 4-bytes words but some of our message structs have odd sizeofs,
use __packed __aligned(4) to avoid potential oopses.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/1583117485-30922-1-git-send-email-Anson.Huang@nxp.com

parent 7375f2ac

drivers/thermal/imx_sc_thermal.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -27,12 +27,12 @@ struct imx_sc_sensor {
		struct req_get_temp {
		u16 resource_id;
		u8 type;
		} __packed;
		} __packed __aligned(4);

		struct resp_get_temp {
		u16 celsius;
		u8 tenths;
		} __packed;
		} __packed __aligned(4);

		struct imx_sc_msg_misc_get_temp {
		struct imx_sc_rpc_msg hdr;
		@@ -40,7 +40,7 @@ struct imx_sc_msg_misc_get_temp {
		struct req_get_temp req;
		struct resp_get_temp resp;
		} data;
		};
		} __packed __aligned(4);

		static int imx_sc_thermal_get_temp(void data, int temp)
		{