Commit 1fcf6891 authored Oct 26, 2020 by Ahmed S. Darwish Committed by Johan Hovold Oct 27, 2020

USB: serial: digi_acceleport: remove in_interrupt() usage



The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

The debug printk() in digi_write() prints in_interrupt() as context
information. This information is imprecise as it does not distinguish
between hard-IRQ or disabled bottom half and it does not consider
disabled interrupts or preemption. It is not really helpful.

Remove the in_interrupt() printout.

Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20201026140313.dpg3hkhkje2os4hw@linutronix.de


[ johan: amend commit message ]
Signed-off-by: Johan Hovold <johan@kernel.org>

parent 3650b228

drivers/usb/serial/digi_acceleport.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -911,9 +911,8 @@ static int digi_write(struct tty_struct tty, struct usb_serial_port port,
		unsigned char *data = port->write_urb->transfer_buffer;
		unsigned long flags = 0;

		dev_dbg(&port->dev,
		"digi_write: TOP: port=%d, count=%d, in_interrupt=%ld\n",
		priv->dp_port_num, count, in_interrupt());
		dev_dbg(&port->dev, "digi_write: TOP: port=%d, count=%d\n",
		priv->dp_port_num, count);

		/* copy user data (which can sleep) before getting spin lock */
		count = min(count, port->bulk_out_size-2);

Admin message