Commit 1fc2b00f authored Apr 10, 2013 by Masatake YAMATO Committed by James Bottomley Apr 11, 2013

[SCSI] libiscsi: avoid unnecessary multiple NULL assignments



In iscsi_free_task, NULL is assigned to task->sc twice: before and
after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
with session->lock, so multiple NULL assignments cause no trouble. But
people reading the source code may be confused.

The second NULL assignment comes from commit:

    3e5c28ad

It seems that the line after kfifo_in invocation was introduced
accidentally.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 5f28897d

drivers/scsi/libiscsi.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -507,7 +507,6 @@ static void iscsi_free_task(struct iscsi_task *task)
		kfifo_in(&session->cmdpool.queue, (void)&task, sizeof(void));

		if (sc) {
		task->sc = NULL;
		/* SCSI eh reuses commands to verify us */
		sc->SCp.ptr = NULL;
		/*

Admin message