Commit 1fbd20f8 authored Apr 03, 2019 by Andrey Ignatov Committed by Daniel Borkmann Apr 05, 2019

bpf: Add missed newline in verifier verbose log



check_stack_access() that prints verbose log is used in
adjust_ptr_min_max_vals() that prints its own verbose log and now they
stick together, e.g.:

  variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16
  size=1R2 stack pointer arithmetic goes out of range, prohibited for
  !root

Add missing newline so that log is more readable:
  variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16 size=1
  R2 stack pointer arithmetic goes out of range, prohibited for !root

Fixes: f1174f77 ("bpf/verifier: rework value tracking")
Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 07f91962

kernel/bpf/verifier.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1426,7 +1426,7 @@ static int check_stack_access(struct bpf_verifier_env *env,
		char tn_buf[48];

		tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
		verbose(env, "variable stack access var_off=%s off=%d size=%d",
		verbose(env, "variable stack access var_off=%s off=%d size=%d\n",
		tn_buf, off, size);
		return -EACCES;
		}

Admin message