ice: Fix bad register reads (1fba4a8a) · Commits · 戴 / test

The "ethtool -d" handler reads registers in the ice_regs_dump_list array and returns read values back to the userspace. The register offsets PFINT0_ITR* are not valid as per the specification and reading these causes a "unable to handle kernel paging request" bug in the driver. Remove these registers from ice_regs_dump_list. Signed-off-by:

Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> Signed-off-by:

Tony Nguyen <anthony.l.nguyen@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/ice/ice_ethtool.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -142,9 +142,6 @@ static const u32 ice_regs_dump_list[] = {
		QINT_RQCTL(0),
		PFINT_OICR_ENA,
		QRX_ITR(0),
		PF0INT_ITR_0(0),
		PF0INT_ITR_1(0),
		PF0INT_ITR_2(0),
		};

		struct ice_priv_flag {

drivers/net/ethernet/intel/ice/ice_hw_autogen.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -6,9 +6,6 @@
		#ifndef _ICE_HW_AUTOGEN_H_
		#define _ICE_HW_AUTOGEN_H_

		#define PF0INT_ITR_0(_i) (0x03000004 + ((_i) * 4096))
		#define PF0INT_ITR_1(_i) (0x03000008 + ((_i) * 4096))
		#define PF0INT_ITR_2(_i) (0x0300000C + ((_i) * 4096))
		#define QTX_COMM_DBELL(_DBQM) (0x002C0000 + ((_DBQM) * 4))
		#define QTX_COMM_HEAD(_DBQM) (0x000E0000 + ((_DBQM) * 4))
		#define QTX_COMM_HEAD_HEAD_S 0

Admin message