Commit 1fa5b2a7 authored Oct 15, 2014 by Paolo Bonzini Committed by Rusty Russell Oct 15, 2014

virito_scsi: use freezable WQ for events



Michael S. Tsirkin noticed a race condition:
we reset device on freeze, but system WQ is still
running so it might try adding bufs to a VQ meanwhile.

To fix, switch to handling events from the freezable WQ.

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent e53fbd11

drivers/scsi/virtio_scsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -390,7 +390,7 @@ static void virtscsi_complete_event(struct virtio_scsi vscsi, void buf)
		{
		struct virtio_scsi_event_node *event_node = buf;

		schedule_work(&event_node->work);
		queue_work(system_freezable_wq, &event_node->work);
		}

		static void virtscsi_event_done(struct virtqueue *vq)

Admin message