ice: Only disable VF state when freeing each VF resources (1f9639d2) · Commits · 戴 / test

It is wrong to set PF disable state flag for all VFs when freeing VF resources - Instead, we should set VF disable state flag for each VF with its resources being returned to the device. Right now, all VF opcodes, mailbox communication to clear its resources as well fails - since we already indicate that PF is in disable state, with all VFs not active. In addition, we don't need to notify VF that PF is intending to reset it, if it is already in disabled state. Signed-off-by:

Akeem G Abodunrin <akeem.g.abodunrin@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -318,8 +318,9 @@ void ice_free_vfs(struct ice_pf *pf)
		pf->num_alloc_vfs = 0;
		for (i = 0; i < tmp; i++) {
		if (test_bit(ICE_VF_STATE_INIT, pf->vf[i].vf_states)) {
		/* disable VF qp mappings */
		/* disable VF qp mappings and set VF disable state */
		ice_dis_vf_mappings(&pf->vf[i]);
		set_bit(ICE_VF_STATE_DIS, pf->vf[i].vf_states);
		ice_free_vf_res(&pf->vf[i]);
		}
		}
		@@ -1303,9 +1304,12 @@ static void ice_vc_notify_vf_reset(struct ice_vf *vf)
		if (!vf \|\| vf->vf_id >= vf->pf->num_alloc_vfs)
		return;

		/* verify if the VF is in either init or active before proceeding */
		if (!test_bit(ICE_VF_STATE_INIT, vf->vf_states) &&
		!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states))
		/* Bail out if VF is in disabled state, neither initialized, nor active
		* state - otherwise proceed with notifications
		*/
		if ((!test_bit(ICE_VF_STATE_INIT, vf->vf_states) &&
		!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) \|\|
		test_bit(ICE_VF_STATE_DIS, vf->vf_states))
		return;

		pfe.event = VIRTCHNL_EVENT_RESET_IMPENDING;

Admin message