Commit 1f85b42a authored by Catalin Marinas's avatar Catalin Marinas Committed by Will Deacon
Browse files

arm64: Revert L1_CACHE_SHIFT back to 6 (64-byte cache line size) 



Commit 97303480 ("arm64: Increase the max granular size") increased
the cache line size to 128 to match Cavium ThunderX, apparently for some
performance benefit which could not be confirmed. This change, however,
has an impact on the network packets allocation in certain
circumstances, requiring slightly over a 4K page with a significant
performance degradation.

This patch reverts L1_CACHE_SHIFT back to 6 (64-byte cache line) while
keeping ARCH_DMA_MINALIGN at 128. The cache_line_size() function was
changed to default to ARCH_DMA_MINALIGN in the absence of a meaningful
CTR_EL0.CWG bit field.

In addition, if a system with ARCH_DMA_MINALIGN < CTR_EL0.CWG is
detected, the kernel will force swiotlb bounce buffering for all
non-coherent devices since DMA cache maintenance on sub-CWG ranges is
not safe, leading to data corruption.

Cc: Tirumalesh Chalamarla <tchalamarla@cavium.com>
Cc: Timur Tabi <timur@codeaurora.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 6b24442d

arch/arm64/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ config ARM64 
	select ARCH_HAS_GIGANTIC_PAGE if (MEMORY_ISOLATION && COMPACTION) || CMA

	select ARCH_HAS_KCOV

	select ARCH_HAS_MEMBARRIER_SYNC_CORE

	select ARCH_HAS_PHYS_TO_DMA

	select ARCH_HAS_SET_MEMORY

	select ARCH_HAS_SG_CHAIN

	select ARCH_HAS_STRICT_KERNEL_RWX

arch/arm64/include/asm/cache.h

+3 −3
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ 
#define ICACHE_POLICY_VIPT	2

#define ICACHE_POLICY_PIPT	3



#define L1_CACHE_SHIFT		7

#define L1_CACHE_SHIFT		(6)

#define L1_CACHE_BYTES		(1 << L1_CACHE_SHIFT)



/*
@@ -39,7 +39,7 @@ 
 * cache before the transfer is done, causing old data to be seen by

 * the CPU.

 */

#define ARCH_DMA_MINALIGN	L1_CACHE_BYTES

#define ARCH_DMA_MINALIGN	(128)



#ifndef __ASSEMBLY__
@@ -73,7 +73,7 @@ static inline u32 cache_type_cwg(void) 
static inline int cache_line_size(void)

{

	u32 cwg = cache_type_cwg();

	return cwg ? 4 << cwg : L1_CACHE_BYTES;

	return cwg ? 4 << cwg : ARCH_DMA_MINALIGN;

}



#endif	/* __ASSEMBLY__ */

arch/arm64/include/asm/dma-direct.h

0 → 100644
+43 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef __ASM_DMA_DIRECT_H

#define __ASM_DMA_DIRECT_H



#include <linux/jump_label.h>

#include <linux/swiotlb.h>



#include <asm/cache.h>



DECLARE_STATIC_KEY_FALSE(swiotlb_noncoherent_bounce);



static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)

{

	dma_addr_t dev_addr = (dma_addr_t)paddr;



	return dev_addr - ((dma_addr_t)dev->dma_pfn_offset << PAGE_SHIFT);

}



static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dev_addr)

{

	phys_addr_t paddr = (phys_addr_t)dev_addr;



	return paddr + ((phys_addr_t)dev->dma_pfn_offset << PAGE_SHIFT);

}



static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)

{

	if (!dev->dma_mask)

		return false;



	/*

	 * Force swiotlb buffer bouncing when ARCH_DMA_MINALIGN < CWG. The

	 * swiotlb bounce buffers are aligned to (1 << IO_TLB_SHIFT).

	 */

	if (static_branch_unlikely(&swiotlb_noncoherent_bounce) &&

	    !is_device_dma_coherent(dev) &&

	    !is_swiotlb_buffer(dma_to_phys(dev, addr)))

		return false;



	return addr + size - 1 <= *dev->dma_mask;

}



#endif /* __ASM_DMA_DIRECT_H */

arch/arm64/kernel/cpufeature.c

+2 −7
Original line number Diff line number Diff line
@@ -1382,7 +1382,6 @@ bool this_cpu_has_cap(unsigned int cap) 
void __init setup_cpu_features(void)

{

	u32 cwg;

	int cls;



	/* Set the CPU feature capabilies */

	setup_feature_capabilities();
@@ -1405,13 +1404,9 @@ void __init setup_cpu_features(void) 
	 * Check for sane CTR_EL0.CWG value.

	 */

	cwg = cache_type_cwg();

	cls = cache_line_size();

	if (!cwg)

		pr_warn("No Cache Writeback Granule information, assuming cache line size %d\n",

			cls);

	if (L1_CACHE_BYTES < cls)

		pr_warn("L1_CACHE_BYTES smaller than the Cache Writeback Granule (%d < %d)\n",

			L1_CACHE_BYTES, cls);

		pr_warn("No Cache Writeback Granule information, assuming %d\n",

			ARCH_DMA_MINALIGN);

}



static bool __maybe_unused

arch/arm64/mm/dma-mapping.c

+17 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 
#include <asm/cacheflush.h>



static int swiotlb __ro_after_init;

DEFINE_STATIC_KEY_FALSE(swiotlb_noncoherent_bounce);



static pgprot_t __get_dma_pgprot(unsigned long attrs, pgprot_t prot,

				 bool coherent)
@@ -504,6 +505,14 @@ static int __init arm64_dma_init(void) 
	    max_pfn > (arm64_dma_phys_limit >> PAGE_SHIFT))

		swiotlb = 1;



	if (WARN_TAINT(ARCH_DMA_MINALIGN < cache_line_size(),

		       TAINT_CPU_OUT_OF_SPEC,

		       "ARCH_DMA_MINALIGN smaller than CTR_EL0.CWG (%d < %d)",

		       ARCH_DMA_MINALIGN, cache_line_size())) {

		swiotlb = 1;

		static_branch_enable(&swiotlb_noncoherent_bounce);

	}



	return atomic_pool_init();

}

arch_initcall(arm64_dma_init);
@@ -882,6 +891,14 @@ static void __iommu_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, 
void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,

			const struct iommu_ops *iommu, bool coherent)

{

	/*

	 * Enable swiotlb for buffer bouncing if ARCH_DMA_MINALIGN < CWG.

	 * dma_capable() forces the actual bounce if the device is

	 * non-coherent.

	 */

	if (static_branch_unlikely(&swiotlb_noncoherent_bounce) && !coherent)

		iommu = NULL;



	if (!dev->dma_ops)

		dev->dma_ops = &arm64_swiotlb_dma_ops;

CRA Git | Maintained and supported by SUSTech CRA and CCSE