Commit 1f722e19 authored by Madalin Bucur's avatar Madalin Bucur Committed by David S. Miller
Browse files

dpaa_eth: remove netdev_err() for user errors 



User reports that an application making an (incorrect) call to
restart AN on a fixed link DPAA interface triggers an error in
the kernel log while the returned EINVAL should be enough.

Reported-by: default avatarJoakim Tjernlund <Joakim.Tjernlund@infinera.com>
Signed-off-by: default avatarMadalin Bucur <madalin.bucur@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 46e93e54

drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c

+4 −12
Original line number Diff line number Diff line
@@ -80,10 +80,8 @@ static char dpaa_stats_global[][ETH_GSTRING_LEN] = { 
static int dpaa_get_link_ksettings(struct net_device *net_dev,

				   struct ethtool_link_ksettings *cmd)

{

	if (!net_dev->phydev) {

		netdev_dbg(net_dev, "phy device not initialized\n");

	if (!net_dev->phydev)

		return 0;

	}



	phy_ethtool_ksettings_get(net_dev->phydev, cmd);
@@ -95,10 +93,8 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev, 
{

	int err;



	if (!net_dev->phydev) {

		netdev_err(net_dev, "phy device not initialized\n");

	if (!net_dev->phydev)

		return -ENODEV;

	}



	err = phy_ethtool_ksettings_set(net_dev->phydev, cmd);

	if (err < 0)
@@ -142,10 +138,8 @@ static int dpaa_nway_reset(struct net_device *net_dev) 
{

	int err;



	if (!net_dev->phydev) {

		netdev_err(net_dev, "phy device not initialized\n");

	if (!net_dev->phydev)

		return -ENODEV;

	}



	err = 0;

	if (net_dev->phydev->autoneg) {
@@ -167,10 +161,8 @@ static void dpaa_get_pauseparam(struct net_device *net_dev, 
	priv = netdev_priv(net_dev);

	mac_dev = priv->mac_dev;



	if (!net_dev->phydev) {

		netdev_err(net_dev, "phy device not initialized\n");

	if (!net_dev->phydev)

		return;

	}



	epause->autoneg = mac_dev->autoneg_pause;

	epause->rx_pause = mac_dev->rx_pause_active;

CRA Git | Maintained and supported by SUSTech CRA and CCSE