extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() (1f4be247) · Commits · 戴 / test

Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assingment if ->probe() fails. Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:

Chanwoo Choi <cw00.choi@samsung.com>

drivers/extcon/extcon-intel-int3496.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -94,8 +94,7 @@ static int int3496_probe(struct platform_device *pdev)
		struct int3496_data *data;
		int ret;

		ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev),
		acpi_int3496_default_gpios);
		ret = devm_acpi_dev_add_driver_gpios(dev, acpi_int3496_default_gpios);
		if (ret) {
		dev_err(dev, "can't add GPIO ACPI mapping\n");
		return ret;
		@@ -169,8 +168,6 @@ static int int3496_remove(struct platform_device *pdev)
		devm_free_irq(&pdev->dev, data->usb_id_irq, data);
		cancel_delayed_work_sync(&data->work);

		acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev));

		return 0;
		}

Admin message