fb_defio: add first_io callback (1f45f9db) · Commits · 戴 / test

With this optional callback the driver is notified when the first page is entered into the pagelist and a new deferred_io call is scheduled. A possible use-case for this is runtime-pm. In the first_io call pm_runtime_get() could be called, which starts an asynchronous runtime_resume of the device. In the deferred_io callback a call to pm_runtime_barrier() makes the sure, the device is resumed by then and a pm_runtime_put() may put the device back to sleep. Also, some SoCs may use the runtime-pm system to determine if they are able to enter deeper idle states. Therefore it is necessary to keep the use-count from the first written page until the conclusion of the screen update, to prevent the system from going to sleep before completing the pending update. Two users of defio were using kmalloc to allocate the structure. These allocations are changed to kzalloc, to prevent uninitialised .first_io members in those drivers. Signed-off-by:

Heiko Stübner <heiko@sntech.de> Signed-off-by:

Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

drivers/video/fb_defio.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -107,6 +107,10 @@ static int fb_deferred_io_mkwrite(struct vm_area_struct *vma,
		/* protect against the workqueue changing the page list */
		mutex_lock(&fbdefio->lock);

		/* first write in this cycle, notify the driver */
		if (fbdefio->first_io && list_empty(&fbdefio->pagelist))
		fbdefio->first_io(info);

		/*
		* We want the page to remain locked from ->page_mkwrite until
		* the PTE is marked dirty to avoid page_mkclean() being called

drivers/video/smscufx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1083,7 +1083,7 @@ static int ufx_ops_open(struct fb_info *info, int user)

		struct fb_deferred_io *fbdefio;

		fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
		fbdefio = kzalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);

		if (fbdefio) {
		fbdefio->delay = UFX_DEFIO_WRITE_DELAY;

drivers/video/udlfb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -893,7 +893,7 @@ static int dlfb_ops_open(struct fb_info *info, int user)

		struct fb_deferred_io *fbdefio;

		fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
		fbdefio = kzalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);

		if (fbdefio) {
		fbdefio->delay = DL_DEFIO_WRITE_DELAY;

include/linux/fb.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -607,6 +607,7 @@ struct fb_deferred_io {
		struct mutex lock; /* mutex that protects the page list */
		struct list_head pagelist; /* list of touched pages */
		/* callback */
		void (first_io)(struct fb_info info);
		void (deferred_io)(struct fb_info info, struct list_head *pagelist);
		};
		#endif

Admin message