Commit 1f3c790b authored Nov 17, 2017 by Randy Dunlap Committed by Linus Torvalds Nov 17, 2017

dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0

line-range is supposed to treat "1-" as "1-endoffile", so
handle the special case by setting last_lineno to UINT_MAX.

Fixes this error:

  dynamic_debug:ddebug_parse_query: last-line:0 < 1st-line:1
  dynamic_debug:ddebug_exec_query: query parse failed

Link: http://lkml.kernel.org/r/10a6a101-e2be-209f-1f41-54637824788e@infradead.org


Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Jason Baron <jbaron@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8c703d66

lib/dynamic_debug.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -360,6 +360,10 @@ static int ddebug_parse_query(char *words[], int nwords,
		if (parse_lineno(last, &query->last_lineno) < 0)
		return -EINVAL;

		/* special case for last lineno not specified */
		if (query->last_lineno == 0)
		query->last_lineno = UINT_MAX;

		if (query->last_lineno < query->first_lineno) {
		pr_err("last-line:%d < 1st-line:%d\n",
		query->last_lineno,

Admin message