Unverified Commit 1f2675f6 authored May 28, 2019 by Georgii Staroselskii Committed by Mark Brown May 29, 2019

ASoC: sun4i-codec: fix first delay on Speaker



Allwinner DAC seems to have a delay in the Speaker audio routing. When
playing a sound for the first time, the sound gets chopped. On a second
play the sound is played correctly. After some time (~5s) the issue gets
back.

This commit seems to be fixing the same issue as bf14da7e but
for another codepath.

This is the DTS that was used to debug the problem.

&codec {
        allwinner,pa-gpios = <&r_pio 0 11 GPIO_ACTIVE_HIGH>; /* PL11 */
        allwinner,audio-routing =
                "Speaker", "LINEOUT";

        status = "okay";
}

Signed-off-by: Georgii Staroselskii <georgii.staroselskii@emlid.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent be1b577d

sound/soc/sunxi/sun4i-codec.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -1329,6 +1329,15 @@ static int sun4i_codec_spk_event(struct snd_soc_dapm_widget *w,
		gpiod_set_value_cansleep(scodec->gpio_pa,
		!!SND_SOC_DAPM_EVENT_ON(event));

		if (SND_SOC_DAPM_EVENT_ON(event)) {
		/*
		* Need a delay to wait for DAC to push the data. 700ms seems
		* to be the best compromise not to feel this delay while
		* playing a sound.
		*/
		msleep(700);
		}

		return 0;
		}

Admin message