Commit 1f2448dc authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

ARM: dts: exynos: Override thermal by label in Exynos4412 Odroids 



Using full paths to extend or override a device tree node is error prone
since if there was a typo error, a new node will be created instead of
extending the node as it was desired.  This will lead to run-time errors
that could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200830135200.24304-27-krzk@kernel.org
parent e4cf0a4d

arch/arm/boot/dts/exynos4412-odroid-common.dtsi

+15 −19
Original line number Diff line number Diff line
@@ -66,25 +66,6 @@ 
			clock-frequency = <24000000>;

		};

	};



	thermal-zones {

		cpu_thermal: cpu-thermal {

			cooling-maps {

				cooling_map0: map0 {

				     /* Corresponds to 800MHz at freq_table */

				     cooling-device = <&cpu0 7 7>, <&cpu1 7 7>,

						      <&cpu2 7 7>, <&cpu3 7 7>;

				};

				cooling_map1: map1 {

				     /* Corresponds to 200MHz at freq_table */

				     cooling-device = <&cpu0 13 13>,

						      <&cpu1 13 13>,

						      <&cpu2 13 13>,

						      <&cpu3 13 13>;

			       };

		       };

		};

	};

};



&bus_dmc {
@@ -174,6 +155,21 @@ 
	};

};



&cpu_thermal {

	cooling-maps {

		cooling_map0: map0 {

			/* Corresponds to 800MHz at freq_table */

			cooling-device = <&cpu0 7 7>, <&cpu1 7 7>,

					 <&cpu2 7 7>, <&cpu3 7 7>;

		};

		cooling_map1: map1 {

			/* Corresponds to 200MHz at freq_table */

			cooling-device = <&cpu0 13 13>, <&cpu1 13 13>,

					 <&cpu2 13 13>, <&cpu3 13 13>;

		};

	};

};



&pinctrl_1 {

	gpio_power_key: power_key {

		samsung,pins = "gpx1-3";

arch/arm/boot/dts/exynos4412-odroidu3.dts

+21 −25
Original line number Diff line number Diff line
@@ -37,9 +37,21 @@ 
		#cooling-cells = <2>;

		cooling-levels = <0 102 170 230>;

	};

};



&adc {

	vdd-supply = <&ldo10_reg>;

	/* Nothing connected to ADC inputs, keep it disabled */

};



/* Supply for LAN9730/SMSC95xx */

&buck8_reg {

	regulator-name = "BUCK8_P3V3";

	regulator-min-microvolt = <3300000>;

	regulator-max-microvolt = <3300000>;

};



	thermal-zones {

		cpu_thermal: cpu-thermal {

&cpu_thermal {

	cooling-maps {

		map0 {

			trip = <&cpu_alert1>;
@@ -49,10 +61,8 @@ 
		};

		map1 {

			trip = <&cpu_alert2>;

				     cooling-device = <&cpu0 15 15>,

						      <&cpu1 15 15>,

						      <&cpu2 15 15>,

						      <&cpu3 15 15>,

			cooling-device = <&cpu0 15 15>, <&cpu1 15 15>,

					 <&cpu2 15 15>, <&cpu3 15 15>,

					 <&fan0 2 3>;

		};

		map2 {
@@ -61,20 +71,6 @@ 
		};

	};

};

	};

};



&adc {

	vdd-supply = <&ldo10_reg>;

	/* Nothing connected to ADC inputs, keep it disabled */

};



/* Supply for LAN9730/SMSC95xx */

&buck8_reg {

	regulator-name = "BUCK8_P3V3";

	regulator-min-microvolt = <3300000>;

	regulator-max-microvolt = <3300000>;

};



&hdmicec {

	needs-hpd;

CRA Git | Maintained and supported by SUSTech CRA and CCSE