Commit 1f23920d authored May 07, 2009 by Felix Blyakher

xfs: fix double unlock in xfs_swap_extents()



Regreesion from commit ef8f7fc5, which rearranged the code in
xfs_swap_extents() leading to double unlock of xfs inode ilock.
That resulted in xfs_fsr deadlocking itself on platforms, which
don't handle double unlock of rw_semaphore nicely. It caused the
count go negative, which represents the write holder, without
really having one. ia64 is one of the platforms where deadlock
was easily reproduced and the fix was tested.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Felix Blyakher <felixb@sgi.com>

parent 28e21170

fs/xfs/xfs_dfrag.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -347,13 +347,15 @@ xfs_swap_extents(

		error = xfs_trans_commit(tp, XFS_TRANS_SWAPEXT);

		out_unlock:
		xfs_iunlock(ip, XFS_ILOCK_EXCL \| XFS_IOLOCK_EXCL);
		xfs_iunlock(tip, XFS_ILOCK_EXCL \| XFS_IOLOCK_EXCL);
		out:
		kmem_free(tempifp);
		return error;

		out_unlock:
		xfs_iunlock(ip, XFS_ILOCK_EXCL \| XFS_IOLOCK_EXCL);
		xfs_iunlock(tip, XFS_ILOCK_EXCL \| XFS_IOLOCK_EXCL);
		goto out;

		out_trans_cancel:
		xfs_trans_cancel(tp, 0);
		goto out_unlock;

Admin message