Commit 1f0d97bb authored Apr 02, 2020 by Tang Bin Committed by Will Deacon Apr 30, 2020

drivers/perf: arm_spe_pmu: Avoid duplicate printouts



platform_get_irq() already screams on failure, so the redundant call to
dev_err() can be removed.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200402120330.19468-1-tangbin@cmss.chinamobile.com


Signed-off-by: Will Deacon <will@kernel.org>

parent 5810f00a

drivers/perf/arm_spe_pmu.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1133,10 +1133,8 @@ static int arm_spe_pmu_irq_probe(struct arm_spe_pmu *spe_pmu)
		struct platform_device *pdev = spe_pmu->pdev;
		int irq = platform_get_irq(pdev, 0);

		if (irq < 0) {
		dev_err(&pdev->dev, "failed to get IRQ (%d)\n", irq);
		if (irq < 0)
		return -ENXIO;
		}

		if (!irq_is_percpu(irq)) {
		dev_err(&pdev->dev, "expected PPI but got SPI (%d)\n", irq);

Admin message