Commit 1f0a5cbf authored by Liviu Dudau's avatar Liviu Dudau Committed by Vinod Koul
Browse files

dmaengine: Fix allocation size for PL330 data buffer depth. 



The datasheet for PL330 says that the data buffer value in the CRD
register is 10bits wide. However, the value stored is "minus one",
which the driver corrects for. Maximum value that the data buffer
depth can have is 1024 lines, which requires 11 bits for storage.

While making updates I found printing the peripheral ID as a hex
value to be more useful as the datasheet shows the values that way.

Signed-off-by: default avatarLiviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent c27f9556

drivers/dma/pl330.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -271,7 +271,7 @@ struct pl330_config { 
#define DMAC_MODE_NS	(1 << 0)

#define DMAC_MODE_NS	(1 << 0)

	unsigned int	mode;

	unsigned int	mode;

	unsigned int	data_bus_width:10; /* In number of bits */

	unsigned int	data_bus_width:10; /* In number of bits */

	unsigned int	data_buf_dep:10;

	unsigned int	data_buf_dep:11;

	unsigned int	num_chan:4;

	unsigned int	num_chan:4;

	unsigned int	num_peri:6;

	unsigned int	num_peri:6;

	u32		peri_ns;

	u32		peri_ns;
@@ -2741,7 +2741,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id) 








	dev_info(&adev->dev,

	dev_info(&adev->dev,

		"Loaded driver for PL330 DMAC-%d\n", adev->periphid);

		"Loaded driver for PL330 DMAC-%x\n", adev->periphid);

	dev_info(&adev->dev,

	dev_info(&adev->dev,

		"\tDBUFF-%ux%ubytes Num_Chans-%u Num_Peri-%u Num_Events-%u\n",

		"\tDBUFF-%ux%ubytes Num_Chans-%u Num_Peri-%u Num_Events-%u\n",

		pcfg->data_buf_dep, pcfg->data_bus_width / 8, pcfg->num_chan,

		pcfg->data_buf_dep, pcfg->data_bus_width / 8, pcfg->num_chan,

CRA Git | Maintained and supported by SUSTech CRA and CCSE