mlxsw: spectrum_trap: Set unreg_action to be SET_FW_DEFAULT (1ef658a3) · Commits · 戴 / test

Currently it does not really matter if it is set to DISCARD or SET_FW_DEFAULT because it is set only during unregister of the listener. The unreg_action is going to be used for disabling the listener too, so change to SET_FW_DEFAULT and ensure the HW is going to behave correctly. Signed-off-by:

Jiri Pirko <jiri@mellanox.com> Signed-off-by:

Ido Schimmel <idosch@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -119,11 +119,11 @@ static void mlxsw_sp_rx_exception_listener(struct sk_buff *skb, u8 local_port,

		#define MLXSW_SP_RXL_DISCARD(_id, _group_id) \
		MLXSW_RXL(mlxsw_sp_rx_drop_listener, DISCARD_##_id, SET_FW_DEFAULT, \
		false, SP_##_group_id, DISCARD)
		false, SP_##_group_id, SET_FW_DEFAULT)

		#define MLXSW_SP_RXL_EXCEPTION(_id, _group_id, _action) \
		MLXSW_RXL(mlxsw_sp_rx_exception_listener, _id, \
		_action, false, SP_##_group_id, DISCARD)
		_action, false, SP_##_group_id, SET_FW_DEFAULT)

		static const struct devlink_trap mlxsw_sp_traps_arr[] = {
		MLXSW_SP_TRAP_DROP(SMAC_MC, L2_DROPS),

Admin message