Commit 1ee44470 authored Apr 12, 2020 by Muchun Song Committed by Ingo Molnar Apr 22, 2020

objtool: Remove redundant .rodata section name comparison



If the prefix of section name is not '.rodata', the following
function call can never return 0.

    strcmp(sec->name, C_JUMP_TABLE_SECTION)

So the name comparison is pointless, just remove it.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent e378fa17

tools/objtool/check.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1354,8 +1354,8 @@ static void mark_rodata(struct objtool_file *file)
		* .rodata.str1.* sections are ignored; they don't contain jump tables.
		*/
		for_each_sec(file, sec) {
		if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) \|\|
		!strcmp(sec->name, C_JUMP_TABLE_SECTION)) {
		if (!strncmp(sec->name, ".rodata", 7) &&
		!strstr(sec->name, ".str1.")) {
		sec->rodata = true;
		found = true;
		}

Admin message