memory_hotplug: add missing newlines to debugging output (1ecc07fd) · Commits · 戴 / test

pages_correctly_probed is missing new lines which means that the line is not printed rightaway but it rather waits for additional printks. Add \n to all three messages in pages_correctly_probed. Link: http://lkml.kernel.org/r/20181218162307.10518-1-mhocko@kernel.org Fixes: ("mm/memory_hotplug: optimize probe routine") Signed-off-by:

Michal Hocko <mhocko@suse.com> Reviewed-by:

Oscar Salvador <osalvador@suse.de> Reviewed-by:

Wei Yang <richard.weiyang@gmail.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

drivers/base/memory.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
		return false;

		if (!present_section_nr(section_nr)) {
		pr_warn("section %ld pfn[%lx, %lx) not present",
		pr_warn("section %ld pfn[%lx, %lx) not present\n",
		section_nr, pfn, pfn + PAGES_PER_SECTION);
		return false;
		} else if (!valid_section_nr(section_nr)) {
		pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
		pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
		section_nr, pfn, pfn + PAGES_PER_SECTION);
		return false;
		} else if (online_section_nr(section_nr)) {
		pr_warn("section %ld pfn[%lx, %lx) is already online",
		pr_warn("section %ld pfn[%lx, %lx) is already online\n",
		section_nr, pfn, pfn + PAGES_PER_SECTION);
		return false;
		}

Admin message