Commit 1eca92ee authored Aug 14, 2019 by Wenwen Wang Committed by David S. Miller Aug 18, 2019

cx82310_eth: fix a memory leak bug



In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
Then, the execution waits for the firmware to become ready. If the firmware
is not ready in time, the execution is terminated. However, the allocated
'dev->partial_data' is not deallocated on this path, leading to a memory
leak bug. To fix this issue, free 'dev->partial_data' before returning the
error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4a4d2d37

drivers/net/usb/cx82310_eth.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,8 @@ static int cx82310_bind(struct usbnet dev, struct usb_interface intf)
		}
		if (!timeout) {
		dev_err(&udev->dev, "firmware not ready in time\n");
		return -ETIMEDOUT;
		ret = -ETIMEDOUT;
		goto err;
		}

		/* enable ethernet mode (?) */

Admin message