Commit 1eca05aa authored Jan 03, 2018 by Yunlei He Committed by Jaegeuk Kim Jan 16, 2018

f2fs: update inode info to inode page for new file



After checkpoint,
 1. creat a new file A ,(with dirty inode && dirty inode page && xattr info)
 2. backgroud wb write back file A inode page (without update from inode cache)
 3. fsync file A, write back inode page of file A with inode cache info
 4. sudden power off before new checkpoint

In this case, recovery process will try to recover a zero inode
page. Inline xattr flag of file A will be miss and xattr info
will be taken as blkaddr index.

Signed-off-by: Yunlei He <heyunlei@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent f66c027e

fs/f2fs/node.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2207,7 +2207,9 @@ void recover_inline_xattr(struct inode inode, struct page page)
		f2fs_bug_on(F2FS_I_SB(inode), IS_ERR(ipage));

		ri = F2FS_INODE(page);
		if (!(ri->i_inline & F2FS_INLINE_XATTR)) {
		if (ri->i_inline & F2FS_INLINE_XATTR) {
		set_inode_flag(inode, FI_INLINE_XATTR);
		} else {
		clear_inode_flag(inode, FI_INLINE_XATTR);
		goto update_inode;
		}

Admin message