Commit 1ec7bae8 authored Mar 01, 2016 by Jouni Malinen Committed by Johannes Berg Mar 01, 2016

mac80211: Fix Public Action frame RX in AP mode



Public Action frames use special rules for how the BSSID field (Address
3) is set. A wildcard BSSID is used in cases where the transmitter and
recipient are not members of the same BSS. As such, we need to accept
Public Action frames with wildcard BSSID.

Commit db8e1732 ("mac80211: ignore frames between TDLS peers when
operating as AP") added a rule that drops Action frames to TDLS-peers
based on an Action frame having different DA (Address 1) and BSSID
(Address 3) values. This is not correct since it misses the possibility
of BSSID being a wildcard BSSID in which case the Address 1 would not
necessarily match.

Fix this by allowing mac80211 to accept wildcard BSSID in an Action
frame when in AP mode.

Fixes: db8e1732 ("mac80211: ignore frames between TDLS peers when operating as AP")
Cc: stable@vger.kernel.org
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 9acc54be

net/mac80211/rx.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3384,6 +3384,7 @@ static bool ieee80211_accept_frame(struct ieee80211_rx_data *rx)
		return false;
		/* ignore action frames to TDLS-peers */
		if (ieee80211_is_action(hdr->frame_control) &&
		!is_broadcast_ether_addr(bssid) &&
		!ether_addr_equal(bssid, hdr->addr1))
		return false;
		}

Admin message