md/raid1: fix write behind issues introduced by bio_clone_bioset_partial (1ec49223) · Commits · 戴 / test

There are two issues, introduced by commit (md/raid1: use bio_clone_bioset_partial() in case of write behind): - bio_clone_bioset_partial() uses bytes instead of sectors as parameters - in writebehind mode, we return bio if all !writemostly disk bios finish, which could happen before writemostly disk bios run. So all writemostly disk bios should have their bvec. Here we just make sure all bios are cloned instead of fast cloned. Reviewed-by:

Ming Lei <tom.leiming@gmail.com> Signed-off-by:

Shaohua Li <shli@fb.com>

drivers/md/raid1.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -1472,8 +1472,8 @@ static void raid1_write_request(struct mddev mddev, struct bio bio)
		!waitqueue_active(&bitmap->behind_wait)) {
		mbio = bio_clone_bioset_partial(bio, GFP_NOIO,
		mddev->bio_set,
		offset,
		max_sectors);
		offset << 9,
		max_sectors << 9);
		alloc_behind_pages(mbio, r1_bio);
		}

		@@ -1485,9 +1485,16 @@ static void raid1_write_request(struct mddev mddev, struct bio bio)
		}

		if (!mbio) {
		if (r1_bio->behind_bvecs)
		mbio = bio_clone_bioset_partial(bio, GFP_NOIO,
		mddev->bio_set,
		offset << 9,
		max_sectors << 9);
		else {
		mbio = bio_clone_fast(bio, GFP_NOIO, mddev->bio_set);
		bio_trim(mbio, offset, max_sectors);
		}
		}

		if (r1_bio->behind_bvecs) {
		struct bio_vec *bvec;

Admin message