Commit 1ebee801 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Eliminate array-index-based RCU primitives 



Now that rcu_access_index() and rcu_dereference_index_check() are no
longer used, the commit removes them from the RCU API.  This means that
RCU's data dependencies now involve only pointers, give or take the
occasional cast to and then back from an integer type to do pointer
arithmetic.  This in turn eliminates the need for a number of operations
on values carrying RCU data dependencies.

Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: linux-edac@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>
Acked-by: default avatarBorislav Petkov <bp@suse.de>
parent e90328b8

include/linux/rcupdate.h

+0 −50
Original line number Diff line number Diff line
@@ -628,21 +628,6 @@ static inline void rcu_preempt_sleep_check(void) 
	((typeof(*p) __force __kernel *)(p)); \

})



#define __rcu_access_index(p, space) \

({ \

	typeof(p) _________p1 = READ_ONCE(p); \

	rcu_dereference_sparse(p, space); \

	(_________p1); \

})

#define __rcu_dereference_index_check(p, c) \

({ \

	/* Dependency order vs. p above. */ \

	typeof(p) _________p1 = lockless_dereference(p); \

	rcu_lockdep_assert(c, \

			   "suspicious rcu_dereference_index_check() usage"); \

	(_________p1); \

})



/**

 * RCU_INITIALIZER() - statically initialize an RCU-protected global variable

 * @v: The value to statically initialize with.
@@ -786,41 +771,6 @@ static inline void rcu_preempt_sleep_check(void) 
 */

#define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu)



/**

 * rcu_access_index() - fetch RCU index with no dereferencing

 * @p: The index to read

 *

 * Return the value of the specified RCU-protected index, but omit the

 * smp_read_barrier_depends() and keep the READ_ONCE().  This is useful

 * when the value of this index is accessed, but the index is not

 * dereferenced, for example, when testing an RCU-protected index against

 * -1.  Although rcu_access_index() may also be used in cases where

 * update-side locks prevent the value of the index from changing, you

 * should instead use rcu_dereference_index_protected() for this use case.

 */

#define rcu_access_index(p) __rcu_access_index((p), __rcu)



/**

 * rcu_dereference_index_check() - rcu_dereference for indices with debug checking

 * @p: The pointer to read, prior to dereferencing

 * @c: The conditions under which the dereference will take place

 *

 * Similar to rcu_dereference_check(), but omits the sparse checking.

 * This allows rcu_dereference_index_check() to be used on integers,

 * which can then be used as array indices.  Attempting to use

 * rcu_dereference_check() on an integer will give compiler warnings

 * because the sparse address-space mechanism relies on dereferencing

 * the RCU-protected pointer.  Dereferencing integers is not something

 * that even gcc will put up with.

 *

 * Note that this function does not implicitly check for RCU read-side

 * critical sections.  If this function gains lots of uses, it might

 * make sense to provide versions for each flavor of RCU, but it does

 * not make sense as of early 2010.

 */

#define rcu_dereference_index_check(p, c) \

	__rcu_dereference_index_check((p), (c))



/**

 * rcu_dereference_protected() - fetch RCU pointer when updates prevented

 * @p: The pointer to read, prior to dereferencing

CRA Git | Maintained and supported by SUSTech CRA and CCSE