Commit 1ebe1eaf authored Jan 18, 2018 by Steven Rostedt (VMware)

tracing: Fix converting enum's from the map in trace_event_eval_update()

Since enums do not get converted by the TRACE_EVENT macro into their values,
the event format displaces the enum name and not the value. This breaks
tools like perf and trace-cmd that need to interpret the raw binary data. To
solve this, an enum map was created to convert these enums into their actual
numbers on boot up. This is done by TRACE_EVENTS() adding a
TRACE_DEFINE_ENUM() macro.

Some enums were not being converted. This was caused by an optization that
had a bug in it.

All calls get checked against this enum map to see if it should be converted
or not, and it compares the call's system to the system that the enum map
was created under. If they match, then they call is processed.

To cut down on the number of iterations needed to find the maps with a
matching system, since calls and maps are grouped by system, when a match is
made, the index into the map array is saved, so that the next call, if it
belongs to the same system as the previous call, could start right at that
array index and not have to scan all the previous arrays.

The problem was, the saved index was used as the variable to know if this is
a call in a new system or not. If the index was zero, it was assumed that
the call is in a new system and would keep incrementing the saved index
until it found a matching system. The issue arises when the first matching
system was at index zero. The next map, if it belonged to the same system,
would then think it was the first match and increment the index to one. If
the next call belong to the same system, it would begin its search of the
maps off by one, and miss the first enum that should be converted. This left
a single enum not converted properly.

Also add a comment to describe exactly what that index was for. It took me a
bit too long to figure out what I was thinking when debugging this issue.

Link: http://lkml.kernel.org/r/717BE572-2070-4C1E-9902-9F2E0FEDA4F8@oracle.com

Cc: stable@vger.kernel.org
Fixes: 0c564a53 ("tracing: Add TRACE_DEFINE_ENUM() macro to map enums to their values")
Reported-by: Chuck Lever <chuck.lever@oracle.com>
Teste-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 0164e0d7

kernel/trace/trace_events.c

+15 −1

Original line number	Diff line number	Diff line
		@@ -2213,6 +2213,7 @@ void trace_event_eval_update(struct trace_eval_map **map, int len)
		{
		struct trace_event_call call, p;
		const char *last_system = NULL;
		bool first = false;
		int last_i;
		int i;

		@@ -2220,15 +2221,28 @@ void trace_event_eval_update(struct trace_eval_map **map, int len)
		list_for_each_entry_safe(call, p, &ftrace_events, list) {
		/* events are usually grouped together with systems */
		if (!last_system \|\| call->class->system != last_system) {
		first = true;
		last_i = 0;
		last_system = call->class->system;
		}

		/*
		* Since calls are grouped by systems, the likelyhood that the
		* next call in the iteration belongs to the same system as the
		* previous call is high. As an optimization, we skip seaching
		* for a map[] that matches the call's system if the last call
		* was from the same system. That's what last_i is for. If the
		* call has the same system as the previous call, then last_i
		* will be the index of the first map[] that has a matching
		* system.
		*/
		for (i = last_i; i < len; i++) {
		if (call->class->system == map[i]->system) {
		/* Save the first system if need be */
		if (!last_i)
		if (first) {
		last_i = i;
		first = false;
		}
		update_event_printk(call, map[i]);
		}
		}

Admin message