Commit 1ebafd15 authored Sep 10, 2018 by Hans de Goede Committed by Greg Kroah-Hartman Sep 11, 2018

staging: vboxvideo: Fix IRQs no longer working



Commit 1daddbc8 ("staging: vboxvideo: Update driver to use
drm_dev_register.") replaced the obsolere drm_get_pci_dev() with
normal pci probe and remove functions.

But the new vbox_pci_probe() is missing a pci_enable_device() call,
causing interrupts to not be delivered. This causes resizes of the
vm window to not get seen by the drm/kms code.

This commit adds the missing pci_enable_device() call, fixing this.

Fixes: 1daddbc8 ("staging: vboxvideo: Update driver to use ...")
Cc: Fabio Rafael da Rosa <fdr@pid42.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 38358415

drivers/staging/vboxvideo/vbox_drv.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -59,6 +59,11 @@ static int vbox_pci_probe(struct pci_dev pdev, const struct pci_device_id ent)
		ret = PTR_ERR(dev);
		goto err_drv_alloc;
		}

		ret = pci_enable_device(pdev);
		if (ret)
		goto err_pci_enable;

		dev->pdev = pdev;
		pci_set_drvdata(pdev, dev);

		@@ -75,6 +80,8 @@ static int vbox_pci_probe(struct pci_dev pdev, const struct pci_device_id ent)
		err_drv_dev_register:
		vbox_driver_unload(dev);
		err_vbox_driver_load:
		pci_disable_device(pdev);
		err_pci_enable:
		drm_dev_put(dev);
		err_drv_alloc:
		return ret;

Admin message