Commit 1e968bf5 authored Apr 21, 2020 by Sami Tolvanen Committed by Josh Poimboeuf May 28, 2020

objtool: Use sh_info to find the base for .rela sections



ELF doesn't require .rela section names to match the base section. Use
the section index in sh_info to find the section instead of looking it
up by name.

LLD, for example, generates a .rela section that doesn't match the base
section name when we merge sections in a linker script for a binary
compiled with -ffunction-sections.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>

parent e000acc1

tools/objtool/elf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -508,7 +508,7 @@ static int read_relas(struct elf *elf)
		if (sec->sh.sh_type != SHT_RELA)
		continue;

		sec->base = find_section_by_name(elf, sec->name + 5);
		sec->base = find_section_by_index(elf, sec->sh.sh_info);
		if (!sec->base) {
		WARN("can't find base section for rela section %s",
		sec->name);

Admin message